[SPARK-26680][SQL] Eagerly create inputVars while conditions are appropriate #23617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix scope of match Add test
srowen
reviewed
Jan 22, 2019
| @@ -159,6 +156,10 @@ trait CodegenSupport extends SparkPlan { | |||
| BoundReference(i, attr.dataType, attr.nullable).genCode(ctx) | |||
| } | |||
| } | |||
| } match { | |||
There was a problem hiding this comment.
I think this construction is confusing. Can this be split into two statements rather than chain a block and match?
|
Test build #101544 has finished for PR 23617 at commit
|
|
aside from sean's comments, lgtm. Also cc @hvanhovell since you reviewed #22789 for SPARK-25767 |
|
Test build #101553 has finished for PR 23617 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 24, 2019
…opriate ## What changes were proposed in this pull request? When a user passes a Stream to groupBy, ```CodegenSupport.consume``` ends up lazily generating ```inputVars``` from a Stream, since the field ```output``` will be a Stream. At the time ```output.zipWithIndex.map``` is called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially created ```inputVars```. As a result, a StackOverflowError occurs. This PR ensures that ```inputVars``` is eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creating ```inputVars``` from ```outputVars``` (SPARK-25767). I simply extended the solution for that code path to encompass both code paths. ## How was this patch tested? SQL unit tests new test python tests Closes #23617 from bersprockets/SPARK-26680_opt1. Authored-by: Bruce Robbins <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit d4a30fa) Signed-off-by: Herman van Hovell <[email protected]>
|
Merged to master/2.4. If we need this in 2.3 as well, then we need to make a backport that fixes the conflicts. |
bersprockets
added a commit
to bersprockets/spark
that referenced
this pull request
Jan 24, 2019
…opriate When a user passes a Stream to groupBy, ```CodegenSupport.consume``` ends up lazily generating ```inputVars``` from a Stream, since the field ```output``` will be a Stream. At the time ```output.zipWithIndex.map``` is called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially created ```inputVars```. As a result, a StackOverflowError occurs. This PR ensures that ```inputVars``` is eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creating ```inputVars``` from ```outputVars``` (SPARK-25767). I simply extended the solution for that code path to encompass both code paths. SQL unit tests new test python tests Closes apache#23617 from bersprockets/SPARK-26680_opt1. Authored-by: Bruce Robbins <[email protected]> Signed-off-by: Herman van Hovell <[email protected]>
|
@hvanhovell @srowen @squito Thanks! I will make a PR for branch-2.3 later today. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 25, 2019
…s while conditions are appropriate ## What changes were proposed in this pull request? Back port of #22789 and #23617 to branch-2.3 When a user passes a Stream to groupBy, ```CodegenSupport.consume``` ends up lazily generating ```inputVars``` from a Stream, since the field ```output``` will be a Stream. At the time ```output.zipWithIndex.map``` is called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially created ```inputVars```. As a result, a StackOverflowError occurs. This PR ensures that ```inputVars``` is eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creating ```inputVars``` from ```outputVars``` (SPARK-25767). I simply extended the solution for that code path to encompass both code paths. ## How was this patch tested? SQL unit tests new test python tests Closes #23642 from bersprockets/SPARK-26680_branch23. Authored-by: Bruce Robbins <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…opriate ## What changes were proposed in this pull request? When a user passes a Stream to groupBy, ```CodegenSupport.consume``` ends up lazily generating ```inputVars``` from a Stream, since the field ```output``` will be a Stream. At the time ```output.zipWithIndex.map``` is called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially created ```inputVars```. As a result, a StackOverflowError occurs. This PR ensures that ```inputVars``` is eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creating ```inputVars``` from ```outputVars``` (SPARK-25767). I simply extended the solution for that code path to encompass both code paths. ## How was this patch tested? SQL unit tests new test python tests Closes apache#23617 from bersprockets/SPARK-26680_opt1. Authored-by: Bruce Robbins <[email protected]> Signed-off-by: Herman van Hovell <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
…opriate ## What changes were proposed in this pull request? When a user passes a Stream to groupBy, ```CodegenSupport.consume``` ends up lazily generating ```inputVars``` from a Stream, since the field ```output``` will be a Stream. At the time ```output.zipWithIndex.map``` is called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially created ```inputVars```. As a result, a StackOverflowError occurs. This PR ensures that ```inputVars``` is eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creating ```inputVars``` from ```outputVars``` (SPARK-25767). I simply extended the solution for that code path to encompass both code paths. ## How was this patch tested? SQL unit tests new test python tests Closes apache#23617 from bersprockets/SPARK-26680_opt1. Authored-by: Bruce Robbins <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit d4a30fa) Signed-off-by: Herman van Hovell <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
…opriate ## What changes were proposed in this pull request? When a user passes a Stream to groupBy, ```CodegenSupport.consume``` ends up lazily generating ```inputVars``` from a Stream, since the field ```output``` will be a Stream. At the time ```output.zipWithIndex.map``` is called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially created ```inputVars```. As a result, a StackOverflowError occurs. This PR ensures that ```inputVars``` is eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creating ```inputVars``` from ```outputVars``` (SPARK-25767). I simply extended the solution for that code path to encompass both code paths. ## How was this patch tested? SQL unit tests new test python tests Closes apache#23617 from bersprockets/SPARK-26680_opt1. Authored-by: Bruce Robbins <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit d4a30fa) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a user passes a Stream to groupBy,
CodegenSupport.consumeends up lazily generatinginputVarsfrom a Stream, since the fieldoutputwill be a Stream. At the timeoutput.zipWithIndex.mapis called, conditions are correct. However, by the time the map operation actually executes, conditions are no longer appropriate. The closure used by the map operation ends up using a reference to the partially createdinputVars. As a result, a StackOverflowError occurs.This PR ensures that
inputVarsis eagerly created while conditions are appropriate. It seems this was also an issue with the code path for creatinginputVarsfromoutputVars(SPARK-25767). I simply extended the solution for that code path to encompass both code paths.How was this patch tested?
SQL unit tests
new test
python tests